Conversation
Contributor
|
We wanted you to add the original, bad hello world example so that the reviewer can comment on the bad code. Then you can make the changes based on the comments. Sorry for not making it more clear earlier. |
Contributor
Author
|
@laisycs Added the bad Hello World code. |
| //Bad comments | ||
| System.out.println( "Hello World!" ); | ||
| // TOBE deleted | ||
| while (true){ |
Contributor
Author
There was a problem hiding this comment.
@laisycs Shuying.. Handled the loop. Please review again.
zuozhiw
added a commit
that referenced
this pull request
Jan 19, 2023
…pport new OpExecConfig interface (#1796) This PR is a follow-up of #1791 , where a new `OpExecConfig` interface is introduced for the new workflow compiler layer. This PR changes the `OperatorDescriptor` interface to use the new `OpExecConfig`. Currently, the old and new interfaces exist in parallel. After all migrations are completed, the old interface will be removed. New interfaces: ``` def newOperatorExecutor(operatorSchemaInfo: OperatorSchemaInfo): NewOpExecConfig = { throw new UnsupportedOperationException( "operator " + operatorIdentifier + " is not migrated to new OpExec API" ) } // a logical operator corresponds multiple physical operators (a small DAG) def operatorExecutorMultiLayer(operatorSchemaInfo: OperatorSchemaInfo): PhysicalPlan = { new PhysicalPlan(List(newOperatorExecutor(operatorSchemaInfo)), List()) ``` Logical operators that correpond to a single physical operator will implement `newOperatorExecutor` interface. Logical operators that correpond to a **multiple** physical operator (such as aggregate) will implement `operatorExecutorMultiLayer` interface.
aglinxinyuan
added a commit
that referenced
this pull request
Apr 29, 2026
The credit-issue-on-pr-merge job's script was truncated mid-statement, causing every PR merge to fail with SyntaxError: Unexpected token ')'. Add the missing per-issue body: skip cross-repo, diff current vs. credited assignees, removeAssignees for those no longer credited, and addAssignees for newly credited authors. Both calls are wrapped in try/catch so a permissions or 422 hiccup on one issue doesn't abort the rest. Verified end-to-end on aglinxinyuan/texera: issue #4 correctly received @aglinxinyuan as assignee after PR #5 merged with 'Closes #4'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Shuying @laisycs ,
Please review my code.
Thanks,
Sandeep