Skip to content

Updated SandeepHelloWorld.java#4

Merged
laisycs merged 3 commits into
masterfrom
sandeep
Mar 30, 2016
Merged

Updated SandeepHelloWorld.java#4
laisycs merged 3 commits into
masterfrom
sandeep

Conversation

@sandeepreddy602
Copy link
Copy Markdown
Contributor

Hey Shuying @laisycs ,

Please review my code.

Thanks,
Sandeep

@chenlica
Copy link
Copy Markdown
Contributor

We wanted you to add the original, bad hello world example so that the reviewer can comment on the bad code. Then you can make the changes based on the comments. Sorry for not making it more clear earlier.

@sandeepreddy602 sandeepreddy602 changed the title Added SandeepHelloWorld.java Updated SandeepHelloWorld.java Mar 29, 2016
@sandeepreddy602
Copy link
Copy Markdown
Contributor Author

@laisycs Added the bad Hello World code.

//Bad comments
System.out.println( "Hello World!" );
// TOBE deleted
while (true){
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix this loop?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laisycs Shuying.. Handled the loop. Please review again.

@laisycs laisycs merged commit 96f3362 into master Mar 30, 2016
@laisycs laisycs deleted the sandeep branch April 1, 2016 01:03
zuozhiw added a commit that referenced this pull request Jan 19, 2023
…pport new OpExecConfig interface (#1796)

This PR is a follow-up of #1791 , where a new `OpExecConfig` interface
is introduced for the new workflow compiler layer. This PR changes the
`OperatorDescriptor` interface to use the new `OpExecConfig`. Currently,
the old and new interfaces exist in parallel. After all migrations are
completed, the old interface will be removed.

New interfaces:
```
  def newOperatorExecutor(operatorSchemaInfo: OperatorSchemaInfo): NewOpExecConfig = {
    throw new UnsupportedOperationException(
      "operator " + operatorIdentifier + " is not migrated to new OpExec API"
    )
  }

  // a logical operator corresponds multiple physical operators (a small DAG)
  def operatorExecutorMultiLayer(operatorSchemaInfo: OperatorSchemaInfo): PhysicalPlan = {
    new PhysicalPlan(List(newOperatorExecutor(operatorSchemaInfo)), List())
```

Logical operators that correpond to a single physical operator will
implement `newOperatorExecutor` interface.
Logical operators that correpond to a **multiple** physical operator
(such as aggregate) will implement `operatorExecutorMultiLayer`
interface.
aglinxinyuan added a commit that referenced this pull request Apr 29, 2026
The credit-issue-on-pr-merge job's script was truncated mid-statement,
causing every PR merge to fail with SyntaxError: Unexpected token ')'.

Add the missing per-issue body: skip cross-repo, diff current vs.
credited assignees, removeAssignees for those no longer credited, and
addAssignees for newly credited authors. Both calls are wrapped in
try/catch so a permissions or 422 hiccup on one issue doesn't abort
the rest.

Verified end-to-end on aglinxinyuan/texera: issue #4 correctly received
@aglinxinyuan as assignee after PR #5 merged with 'Closes #4'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants